Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add console as logging encoding type #4549

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Add console as logging encoding type #4549

merged 3 commits into from
Oct 7, 2021

Conversation

longquanzheng
Copy link
Contributor

What changed?

Add console as logging encoding type

Why?
My hosted cluster can't use JSON format(it will trigger Kibana indexing but our Kibana/ElasticSearch couldn't handle Cadence's fields)

How did you test it?
Testing with my server.

Potential risks

Release notes

Documentation Changes

@longquanzheng longquanzheng merged commit 37e9845 into master Oct 7, 2021
@longquanzheng longquanzheng deleted the qlong-log-type branch October 7, 2021 22:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build a8aa1d8b-3933-4d92-aed3-dfbb1eb4a7fd

  • 3 of 8 (37.5%) changed or added relevant lines in 1 file are covered.
  • 38 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.681%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/config/log.go 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_builder.go 2 69.77%
service/history/shard/context.go 2 65.93%
service/matching/matcher.go 2 91.46%
common/cache/lru.go 3 90.73%
service/history/queue/timer_gate.go 3 95.83%
service/history/queue/timer_queue_processor_base.go 4 78.83%
service/history/task/transfer_standby_task_executor.go 4 90.4%
common/persistence/nosql/nosqlExecutionStore.go 5 61.06%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 13 53.98%
Totals Coverage Status
Change from base Build 47cb9813-871f-4383-8a85-5f77df85fbb6: -0.02%
Covered Lines: 81005
Relevant Lines: 142914
💛 - Coveralls

longquanzheng added a commit that referenced this pull request Oct 8, 2021
@longquanzheng
Add console as logging encoding type (#4549)
84b8d79
longquanzheng added a commit that referenced this pull request Oct 20, 2021
@longquanzheng
Add console as logging encoding type (#4549)
41e9b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longquanzheng @coveralls @yux0